[WEB-5 SYNTAX] white40 updates #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
somethiiing
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
(white40 and white70) are also duplicated b/c they appeared in the
In dark mode, it makes it pretty clear which background colors are broken in syntax -- white40, white70, gray270:
allColors.tsfile twice.The reason for this is because the
colors.module.cssfile only had cambio class names for these e.g..cambioWhite40,.cambioWhite70,.cambioGray270vs
.white40,.white70,.gray270Because of this, the background color css lookup wasn't working because "white40" didn't map to any css classes.
After change:
Question, should we get rid of all classes that start with
.cambio*? And do we need to distinguish cambio specific colors in ourallColors.tsfile anymore? I don't think any of the cambio classes are being accessed anymore, so the css seems safe to remove? I can do that in a follow up PR